Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the discovered version manager logging as [object Object] #1920

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Earlopain
Copy link
Contributor

Motivation

This was missed in #1831

Automated Tests

Logs aren't tested at the moment.

Manual Tests

Just boot up and check the logs

@Earlopain Earlopain requested a review from a team as a code owner April 12, 2024 08:05
@Earlopain Earlopain requested review from andyw8 and vinistock April 12, 2024 08:05
@vinistock vinistock added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Apr 12, 2024
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@vinistock vinistock merged commit 6883ece into Shopify:main Apr 12, 2024
22 of 23 checks passed
@Earlopain Earlopain deleted the manager-logging branch April 12, 2024 17:38
Earlopain added a commit to Earlopain/ruby-lsp that referenced this pull request Apr 18, 2024
andyw8 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants