Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide 'Rename Symbol' when not available #2854

Open
andyw8 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2894
Open

Hide 'Rename Symbol' when not available #2854

andyw8 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2894

Comments

@andyw8
Copy link
Contributor

andyw8 commented Nov 14, 2024

Rename Symbol is not available in some cases, e.g. for locals, so trying to use Rename Symbol will result in a failure.

We can prevent the option for appearing using textDocument/prepareRename.
@rogancodes
Copy link
Contributor

@andyw8 I have some questions

  1. Do we need to check if prepareSupport is provided by the client before enabling prepare_provider, or should we enable prepare_provider by default?

  2. The renaming option will only be provided if the selected node is a constant type node, correct?

@rogancodes rogancodes linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Prepare Rename Request rogancodes/ruby-lsp
2 participants
@andyw8 @rogancodes