Move Sorbet level and locate_first_within_range to RubyDocument
#2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
st0012
approved these changes
Aug 13, 2024
Indeed, but I wanted to try to reduce the size of the PRs as much as I could. It's implemented in #2436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continuing the work to properly separate the document concerns and eventually support RBS files, both Sorbet level and
locate_first_within_rangeare specific to Ruby files only.Implementation
Moved both
sorbet_levelandlocate_first_within_rangetoRubyDocumentand updated the references accordingly.Automated Tests
Existing tests should cover this refactor.