Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn/Refuse to install if ruby-lsp resolves to old versions #1945

Closed
Earlopain opened this issue Apr 16, 2024 · 8 comments
Closed

Warn/Refuse to install if ruby-lsp resolves to old versions #1945

Earlopain opened this issue Apr 16, 2024 · 8 comments
Assignees
Labels
bug Something isn't working help-wanted Extra attention is needed Stale

Comments

@Earlopain
Copy link
Contributor

Earlopain commented Apr 16, 2024

Description

rubocop currently has a dev dependency on the latest prism version >= 0.25 which this gem doesn't advertise support for at the moment.

During resolution, this results in a ruby-lsp version without prism as a dependency to be choosen, 0.11.2 from october last year. It seems to mostly work but obviously a bunch of stuff is missing.

@Earlopain Earlopain added the bug Something isn't working label Apr 16, 2024
@andyw8
Copy link
Contributor

andyw8 commented Apr 17, 2024

There should be a new release of Prism today, which will unblock this: #1913 #1953

@andyw8
Copy link
Contributor

andyw8 commented Apr 22, 2024

Discussed with the team today:

  • We will decide on what is considered an 'old' server version, perhaps v0.12 where Prism was introduced. Over time, we may bump this to a more recent version.
  • When we detect an old server version, we'll show a warning in the extension. This will link to the troubleshooting guide, in a new section explaining possible causes of the server gem being outdated (e.g. the YARP/Prism issue). There will be an option to snooze/ignore the warning.
  • In the EDITORS.md doc we'll also explain the potential problem, for the benefit of those not using VS Code.

@andyw8 andyw8 added the help-wanted Extra attention is needed label Apr 22, 2024
@stathis-alexander
Copy link

This is still occurring. Prism is resolving to 0.29, but ruby-lsp resolves to v11.2 because v16.6 requires prism <0.28. This is a pretty significant regression.

Can we maybe consider using pessimistic dependencies here so that new versions don't downgrade us?

s.add_dependency("prism", "~>0.23")

@andyw8
Copy link
Contributor

andyw8 commented May 29, 2024

@kddnewton confirmed the next release of Prism will be 1.0, so this will become less of a problem soon.

@Earlopain
Copy link
Contributor Author

Earlopain commented Jun 10, 2024

Noting that I ran into this again today while working on RuboCop since it aggressively keeps up with prism updates.

@andyw8
Copy link
Contributor

andyw8 commented Jun 11, 2024

We've updated for Prism v0.30.0, and will release shortly.

This should be the last time we run into this.

@andyw8
Copy link
Contributor

andyw8 commented Jun 11, 2024

Released: https://rubygems.org/gems/ruby-lsp/versions/0.17.3

Copy link
Contributor

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Aug 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help-wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

3 participants