Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching for excluded_patterns in .index.yml #1847

Closed
andyw8 opened this issue Mar 27, 2024 · 4 comments
Closed

Matching for excluded_patterns in .index.yml #1847

andyw8 opened this issue Mar 27, 2024 · 4 comments
Labels
bug Something isn't working Stale

Comments

@andyw8
Copy link
Contributor

andyw8 commented Mar 27, 2024

As mentioned in #1827

Let's say we have a file abc.rb that we want to exclude from indexing.

If we try exclude it in index.yml with:

excluded_patterns:
  - "abc.rb"

or

excluded_patterns:
  - "/abc.rb"

then it will still be indexed. Instead we need to write:

excluded_patterns:
  - "**/abc.rb"

which is not so obvious, and is different from other exclusion mechanism such as .gitignore.

Copy link
Contributor

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label May 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
@andyw8
Copy link
Contributor Author

andyw8 commented Jun 10, 2024

@vinistock @st0012 this seems like a bug, right?

(I know we're planning to eliminate the config file, but this would likely also apply to the config settings approach)

@andyw8 andyw8 reopened this Jun 10, 2024
@andyw8 andyw8 added bug Something isn't working and removed Stale labels Jun 10, 2024
@andyw8
Copy link
Contributor Author

andyw8 commented Jul 18, 2024

Note: Even though we are deprecating .index.yml this may still be an issue for the indexing configuration.

Copy link
Contributor

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Sep 17, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

1 participant