Hover informations seems offset by non-ascii characters

[frabr]

Operating System

fedora 39

Ruby version

3.1

Project has a bundle

• Has bundle

Ruby version manager being used

rbenv

Description

Hi,
Thank you for your amazing work !
I noticed a strange behavior while using ruby-lsp extension in visual studio code. It seems that non-ascii characters are offsetting hovers to the right/bottom. Would it have something to do with counting charaters bytewise vs scalar (utf-8) ?
This piece of code should be sufficient for reproduction :

  array = []
  # éééééééééééééééééééééé
  puts "çççççççççççççççççççççç"
  array.each
  
  # each hover def will be around-->here<--

Maybe I'm doing something wrong with my setup but I couldn't find anywhere to define encoding or stuff like that.

[vinistock]

Hey! Thank you for the kind words.

I suspect this is related to #1251. The Prism parser returns locations based on bytes instead of characters and we need to better account for that.

This is specific to the Ruby LSP server, so I'm transferring the issue there.

[vinistock]

Since this issue is a duplicate of #1251, I'm going to close this issue to centralize all discussions there. PR #2619 is about to fix this.