Add association augmentations #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/add_extend_augmentation
branch
3 times, most recently
from
d3e0850 to
c99069c
Compare
vinistock
force-pushed
the
vs-add-belongs-to-augmentation
branch
from
b32fbc5 to
41f4227
Compare
st0012
approved these changes
Aug 8, 2024
vinistock
force-pushed
the
vs-add-belongs-to-augmentation
branch
from
41f4227 to
0fb257d
Compare
Yes. We'll need to map everything that gets generated dynamically so that we can cover all methods available. It might be worth checking the stuff generated by Tapioca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another example of how we can use indexing augmentations Shopify/ruby-lsp#2358.
This PR starts handling association DSLs such as has_one and belongs_to, creating the accessor methods that are generated dynamically when invoking them.