Force docker image to use packaged WebUI #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will have a side effect where if an existing docker container is updated, any old WebUI will be forcibly removed and replaced with a symlink.
|
FYI - there is further discussion going on about this internally about some earlier decisions, etc |
|
No worries. This is just what I had in mind as a quick fix if anything. I know there's a lot that has to be factored in before making a decision where to go. This is by no means meant to be a final solution, so I won't mind if it's turned down :) |
|
@hidden4003 @harshithmohan this is done, right? |
|
Not really, it will force all users mount additional docker volume for webui files, I don't see the point in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#989
This will have a side effect where if an existing docker container is updated, any old WebUI will be forcibly removed and replaced with a symlink.