Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datetime to datetime2 on TMDB Tables for MSSQL #1210

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

krbrs
Copy link
Contributor

@krbrs krbrs commented Dec 13, 2024

Fixes The conversion of a datetime2 data type to a datetime data type resulted in an out-of-range value. on MSSQL

so if one migration fails, it won't be stuck because the other succeeded
Drop default constraint and change datetime to datetime2
@revam revam merged commit 5a1bc7f into ShokoAnime:master Dec 15, 2024
Copy link

sentry-io bot commented Dec 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NHibernate.Exceptions.GenericADOException: could not execute native bulk manipulation query:ALTER TABLE AniDB_Creator DROP CONSTRAINT [SQL: ... Databases/SQLServer.cs in void SQLServer.DropDe... View Issue

Did you find this useful? React with a 👍 or 👎

@krbrs
Copy link
Contributor Author

krbrs commented Dec 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NHibernate.Exceptions.GenericADOException: could not execute native bulk manipulation query:ALTER TABLE AniDB_Creator DROP CONSTRAINT [SQL: ... Databases/SQLServer.cs in void SQLServer.DropDe... View Issue

Did you find this useful? React with a 👍 or 👎

This was actually me running the schema changes on an already altered DB where the constraint was deleted by hand.
After adding it by hand and restarting server the problem was gone :) Also the prod DB change went well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants