Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving file on import not working #1209

Open
jmediamanager opened this issue Dec 12, 2024 · 12 comments
Open

Moving file on import not working #1209

jmediamanager opened this issue Dec 12, 2024 · 12 comments

Comments

@jmediamanager
Copy link
Member

VERSION INFORMATION

Server Version: v5.0.0.43, Channel: Dev, Tag: v5.0.0-dev.43, Commit: d66b282

LOG FILE

2024-12-12.log

DESCRIPTION

Get the follow errors when trying to process files from the drop folder

Warn|Shoko.Server.Renamer.RenameFileService > An error occurred while trying to find a destination for E:\AnimeDrop\[SubsPlease] Amagami-san Chi no Enmusubi - 03 (1080p) [8606E7CF].mkv: The renamer "WebAOMRenamer" could not find a valid destination.

STEPS TO REPRODUCE

  1. Setup an Import Folder with type = Drop
  2. Setup an Import Folder with type = Destination
  3. Scan the Drop Import Folder
  4. Verify the error/warning in log
  5. Verify that the file has been added to the collection successfully (can see in episode of collection tab)
  6. Verify that the folder has NOT been moved to the destination

NOTE - This is a fresh install, and by default the renamer script was empty
I created a new rename script with default WebAOM settings and set it as default

@revam
Copy link
Member

revam commented Dec 12, 2024

@harshithmohan didn't you fix this in a daily? idr which version.

@harshithmohan
Copy link
Member

harshithmohan commented Dec 12, 2024

@harshithmohan didn't you fix this in a daily? idr which version.

I did, in 5.0.0.55

@revam
Copy link
Member

revam commented Dec 12, 2024

so @jmediamanager it should be fixed in a newer daily, and in the next stable, so closing this now. also hello. 👋

@revam revam closed this as completed Dec 12, 2024
@harshithmohan
Copy link
Member

Just to add, it won't automatically fix it for everyone when they update. It's fixed for new users

@jmediamanager
Copy link
Member Author

@revam hello :)
@harshithmohan if only fixed for new users, does it mean I have to start from scratch?

@revam
Copy link
Member

revam commented Dec 12, 2024

didn't you already fix it by creating a new renamer config and setting said config as the default config to use? @jmediamanager

@jmediamanager
Copy link
Member Author

jmediamanager commented Dec 12, 2024

didn't you already fix it by creating a new renamer config and setting said config as the default config to use? @jmediamanager

Yup, updated to 5.0.0.86
Created a new renamer after the update and still having the same issue. Attaching log if relevant
2024-12-13.log

And just to clarify, creating a new config didn't fix it before the update either

@jmediamanager
Copy link
Member Author

@revam @harshithmohan FYI - I traced through the code myself, and found that it was failing on the disk space checks
So I set the setting for SkipDiskSpaceChecks to true, and now the moving works fine
Although it renames the file now, even though I have "Rename on import" disabled, but I can live with that

@harshithmohan
Copy link
Member

I thought we were talking about the script being empty. That was fixed 😅

@jmediamanager
Copy link
Member Author

jmediamanager commented Dec 13, 2024

Oh well yes I guess the script was fixed then :)
But not the issue I raised

@harshithmohan harshithmohan reopened this Dec 13, 2024
@revam
Copy link
Member

revam commented Dec 14, 2024

@revam @harshithmohan FYI - I traced through the code myself, and found that it was failing on the disk space checks So I set the setting for SkipDiskSpaceChecks to true, and now the moving works fine Although it renames the file now, even though I have "Rename on import" disabled, but I can live with that

Was it during an automatic rename/move job or in the renamer utility in the Web UI that it potentially wasn't respecting the "Rename on Import" setting?

@jmediamanager
Copy link
Member Author

During the import process (i.e. press "rescan folder" from the Web UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants