Fix file relocation without rename #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to look at the new renamer internals for the latter change, but the success change seems to be fine. Will check when I get home. |
revam
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With "Move on import" enabled and "Rename on import" disabled the file remains in the import folder for two reasons:
WebAOMRenamer.csthe variablesuccessis always false, unlessGetNewFileNameis called (only if rename is enabled)VideoLocal_PlaceService.csthere is a check onresult.FileName, which is always null if the rename is disabled, and the file is never movedThis commit should fix that behavior.