Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to access files and folders #1143

Open
MikePrime21 opened this issue Nov 17, 2024 · 6 comments
Open

Need to access files and folders #1143

MikePrime21 opened this issue Nov 17, 2024 · 6 comments

Comments

@MikePrime21
Copy link

In Shoko Desktop, I could map the root path to a local path on my computer. I need the same ability on the WebUI. Maybe you can save it in local storage or something on the browser. I know for files I think you can use the file:/// syntax, and let my browser launch the default app. For folders, I'm more than willing to just copy the folder path and paste it into windows explorer. Even better if a button could copy it for me.

When I manage my library I tend to need to open the folders and files to see what I want to keep and what I can remove. I don't need it to act like a player, I just need a quick way to switch to explorer or open media files.

@ElementalCrisis
Copy link
Member

ElementalCrisis commented Nov 17, 2024

I can see the benefits of this but not sure if the work required to add support for file:// would be worth it.

@harshithmohan thoughts?

@harshithmohan
Copy link
Member

harshithmohan commented Nov 17, 2024

We can't guarantee the existence of localStorage, we might delete it at any point between updates or wherever required so it'll be an inconsistent feature. If @revam has gotten platback working, that's a far better way to do it, imo.

@MikePrime21
Copy link
Author

I consider the file:/// stuff just a bonus. My main concern is opening windows explorer. If you had a copy button for the folder path then you could check local storage for the mapping. If no mapping exists, you could prompt it in a modal or something. If I'm making decisions on deleting or moving files, I usually want to view it in explorer where I can compare file sizes, dates, and so on.

I'm not really picky here, because truthfully you could make the mapping a global setting used across all connections and it would probably satisfy most people. Especially if I map it using a unc path.

@revam
Copy link
Member

revam commented Nov 17, 2024

  1. not everyone is using windows
  2. we already have a release management utility, and are happy to receive feedback for improvements you can think of, if any. also some of the sub utilities within the release management utility are not implemented yet (e.g. duplicate files of the same hash utility, auto quailty filtering utility, etc.)
  3. there is no consistent way for a website running in the browser to tell the browser "hey, the user wants to open exporer.exe at this folder path," and if there were, then I'd be really nervous.

back to you, @harshithmohan 🫡

@MikePrime21
Copy link
Author

I'm not asking for it to open in explorer. I just want to copy the path. Here is an example.

image

The location says '/mnt/anime/Tower of God/'. But that is the location local to my docker container. If I copy and paste that into windows explorer or any file browser no matter your OS, it will not resolve because its local to the shoko host server.

On my machine I have a mapped network drive, 'M:\Anime\Tower of God'. I want to hit a copy button and you convert that '/mnt/anime/Tower of God/' to 'M:\Anime\Tower of God' and put it in my clipboard. Then I just paste that into explorer or whatever file manager you are using.

@ElementalCrisis
Copy link
Member

ElementalCrisis commented Nov 22, 2024

Hmm, I don't like the idea of a copy button not copying what its next to.

/mnt/anime/Tower of God/  |  M:\Anime\Tower of God 

Is probably how I would want it to look but that could get messy with longer names and less width.

@revam I can see the use of adding local mapping for folder imports, how difficult would it be to add to server? For Web UI, a basic text box, no folder selector and no validation, entirely on the user to input it correctly for the simple process of copying it.

We could also add it in other locations where it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants