Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the Hidden defines in the schema be exported ? #1760

Open
FFengIll opened this issue Mar 1, 2024 · 3 comments
Open

Will the Hidden defines in the schema be exported ? #1760

FFengIll opened this issue Mar 1, 2024 · 3 comments

Comments

@FFengIll
Copy link

FFengIll commented Mar 1, 2024

I see some nodes, edges, properties are defined in Hidden.scala, and they can not be used in protobuf and so on.
Especially, the build logic filtered the Hidden.

May I kindly request an explanation for this behavior?

@mpollmeier
Copy link
Contributor

mpollmeier commented Mar 1, 2024

Did you read the Hidden.description yet? That explains it

override def description: String =
"""
|The schema elements defined here are NOT included on the schema website.
|These are schema elements that we are using but would like to rework
|in the future and not make part of the standard.
|""".stripMargin

For reference, and a bit more context: #1340

@FFengIll
Copy link
Author

FFengIll commented Mar 3, 2024

Did you read the Hidden.description yet? That explains it

I am sorry I have not make a good issue, and I do review all content in the Hidden.

What I do really want to know is Can we update the schema? Or make the Hidden exported in protobuf?


Keep json schema is resonable, but why do not exported full protobuf define?

@mpollmeier
Copy link
Contributor

I can see your point. @fabsx00 since you brought this in initially, do you have any thoughts on this?

@FFengIll FFengIll changed the title Why some defines in the schema are Hidden? Will the Hidden defines in the schema be exported ? Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants