Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle TSLint Errors #404

Open
Tracked by #397
youngkidwarrior opened this issue Nov 1, 2021 · 0 comments
Open
Tracked by #397

Handle TSLint Errors #404

youngkidwarrior opened this issue Nov 1, 2021 · 0 comments
Assignees
@stormcloud266 @youngkidwarrior

Comments

@youngkidwarrior
Copy link
Member

youngkidwarrior commented Nov 1, 2021 •
edited
Loading

User Story

As a ...

Developer

I want ...

To ensure type safety while reviewing code

So that ...

We avoid silly bugs and runtime errors

Comments and Outliers

Currently we have a few 100 TSLint errors. This is a big issue. It might benefit us to pair on this task.

Some errors are more difficult than others. For example, circular dependency errors can be a huge pain in the ass and require a great deal of file restructuring. Generally the rules @youngkidwarrior setup are industry standard, but they can be difficult to accomplish and may benefit from a rule change to increase dev speed.

Acceptance Criteria

Scenario:

Given I am running compiling and code inside the monorepo

When I run the linter
Then it should only allow commits/pushes when the linter is succesful
@youngkidwarrior youngkidwarrior mentioned this issue Nov 1, 2021
Open
5 tasks
@youngkidwarrior youngkidwarrior changed the title Handle TSLint Handle TSLint Errors Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stormcloud266 stormcloud266

@youngkidwarrior youngkidwarrior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stormcloud266 @youngkidwarrior