-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize development infrastructure #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completely eliminate setup.py - this required tinkering with some of the setup.py calls in tox. Additionally, by moving to setuptools-scm, the need for MANIFEST.in has been eliminated.
Also flake8-blind-except and flake8-builtins.
Also add flake8-executable, flake8-implicit-str-concat, flake8-import-conventions, and flake8-pie.
Also flake8-tidy-imports and flake8-type-checking
This will allow natsort to have a single source of truth for the current version.
The goal is to only deploy from CI.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 99.50% 98.50% -1.00%
==========================================
Files 10 10
Lines 601 603 +2
==========================================
- Hits 598 594 -4
- Misses 3 9 +6 ☔ View full report in Codecov by Sentry. |
SethMMorton
force-pushed
the
modernize-dev-infra
branch
from
October 10, 2024 05:57
3391dd2
to
46484e4
Compare
SethMMorton
force-pushed
the
modernize-dev-infra
branch
from
October 10, 2024 07:14
d730607
to
df88fce
Compare
SethMMorton
force-pushed
the
modernize-dev-infra
branch
from
October 10, 2024 07:20
df88fce
to
1e3c261
Compare
SethMMorton
force-pushed
the
modernize-dev-infra
branch
from
October 10, 2024 07:21
1e3c261
to
5ac16f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black
andflake8
toruff
tox
) topyproject.toml
setuptools_scm
to manage the version string