Provide RepositoryBranch metadata for package #24
Conversation
As documented in nuget (https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets) you can provide not only the repo URL, type and commit, but also the branch. But this information is not populated by default by the SourceLink package, neither the ReproducibleBuilds (unless the PR at dotnet/reproducible-builds#27 is merged). So just bring the code in that PR here until that's merged and shipped. Fixes Sergio0694#23
| @@ -85,7 +85,38 @@ | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(RepositoryBranch)' == ''"> | |||
There was a problem hiding this comment.
This is a lot of code and I don't really it's worth adding it, especially given the fix is already pending in the official package. I'd rather just wait for that to be available, and then we can just update this PR to bump the dependency 🙂
There was a problem hiding this comment.
Yeah, that might be best. Also, if you only build on GH actions, might be worth keeping just that single part?
There was a problem hiding this comment.
Maybe, but given you've already opened a PR in ther and it also already has an approval, I'd rather just wait for that one to be in so we can do this properly from the start. I can leave this open if you want, so you can then just rebase and bump that dependency 🙂
|
Closing, since the same fix has been merged into https://github.com/dotnet/reproducible-builds, so it'll propagate here whenever they push a new release that we can also reference. I'll update and publish a new version of PolySharp when that happens. Thank you for contributing that upstream! 🙂 |
|
Hey @Sergio0694, TBH that project seems to be pretty much dead. No releases since Nov-2021 and nobody is actively answering anything there. Perhaps go the other way and take the change here and delete once they release? |
As documented in nuget (https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets) you can provide not only the repo URL, type and commit, but also the branch. But this information is not populated by default by the SourceLink package, neither the ReproducibleBuilds (unless the PR at dotnet/reproducible-builds#27 is merged).
So just bring the code in that PR here until that's merged and shipped.
Fixes #23