-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Meteor.js #1298
Comments
I like your idea and I'm willing to back it up. |
Thanks great write-up. Glad to see meteor integration kicking off. Let me know whatever assistance you need. Once code starts forming I can add you to I also encourage everyone to fill out the form in the readme to sign up for slack access. Will be useful for organizing. |
Great! Good news then ;-) what would you prefer as the Meteor organization name? Consider that publishes packages come in the form 'organization:package_name' so it could be something like:
or:
That's mostly up to you I guess! |
We already have an organization set-up for Semantic-Org on GitHub. So I think it would make sense to keep it consistent on atmosphere. I'm not too familiar with naming conventions for Meteor packages. So whatever pattern you see most commonly used, I think is fine. |
ok so I'd say lets go for Then it could be:
But just in case we'll decide to public also single modules... otherwise Thoughts? |
Just registered
As the semantic source uses less i would suggest dropping css and just use less by default. |
These seems perfect. I think the |
Hi @nooitaf! @jlukic please register yourself as a developer on meteor.com (top right corner...) possibly keeping your username ;-) |
All added :) |
well done! |
Agree with that. We should be careful with publishing since there is no way to fix mistake without increasing version number. Should we all work in Semantic-Org's repositories? @jlukic |
I've given invites to all those currently in conversation to join Semantic-Org. You should also have complete admin access to Semantic-UI-Meteor repo. I'll trust it to your organizing guidance. You should also have the ability to invite and add additional members to your team if you need to do so. |
I am still trying to wrap my head around a good way/balance of usability and advanced settings. I agree that we should have a solid system (clear for the user) before we publish. @jlukic nice :) |
Maybe we could make |
Also, I agree that we should only use |
Thanks @jlukic! So welcome on board for the Meteor integration to all of us! What do you think about bringing on the discussion as a first issue on the newly created Semantic-UI-Meteor? |
@splendido go for it ;) |
@splendido: Thanks for taking the initiative! I'm very glad to see my official integrations effort picking up speed! I've also squatted the I'll let you guys run with this! Glad to have been of help. |
FYI - I noticed the comment about not doing a mistaken publish and burning a version number. In Meteor 0.9.3 they added special semver support for wrapped packages to allow you to keep the normal semver consistent with a release even if you did make a mistake :) For any sort of wrapped package you can set the version to "x.x.x_x". You can read it on the blog at https://www.meteor.com/blog/2014/09/25/meteor-093-packaging-system-updates. |
Yeah, that's true. Thanks for remembering us. I think it is not only about making a silly mistake you can revert with another publish like I wouldn't publish a |
semantic:ui - everything that's necessary to get basic semantic-ui going. This should have less as dependency and use semantic-ui less source directly as @nooitaf said. semantic:ui- - semantic-ui components/modules/whatever, should have semantic:ui as dependency semantic:ui-less - should have weak dependency on semantic:ui and make the necessary setup if semantic:ui package is avaiable. This package should also have it's less files use .import.less to make semantic:ui-less- - Same as above... Something like this maybe? |
Another approach is semanticui:full |
I like the idea to have a base package containing all Then |
What i meant was semantic:ui is depending on the less package and adds .less files that gets automagically compiled as css then we would have semantic:ui-less which would have .import.less files instead |
We don't need "-less" suffix if we will only work with less and not with css. It will be compiled to css anyways so there is no need to state less in package name. It will be easier to remember and more consistent to have only lets say |
Keep it simple and as short as possible. I think that is important enough. |
Ok, same thing. |
This may help - I've improved my Meteor packaging scripts to test and publish multiple packages out of one repo - https://github.com/RubaXa/Sortable/tree/dev/meteor |
thanks :) 😸 |
Hey its been a week, just want to check in with everyone. See what I can do to help get the ball moving again. |
👍 There are various packages with Semantic UI for Meteor but there's a big need for a canonical way of making customizations to the default styles of Semantic. |
Guys, can anyone give some update about meteor integration? what is needed to make this fast? |
@PavanKu Main Discussion is at Semantic-Org/Semantic-UI-Meteor#1 @splendido did a good start on how to make publishing easy for the maintainer, but the 'theme/customization' issue is still unclear i think. |
The way I understand it, theming is mostly about overwriting variables in the LESS files of Semantic UI. Does LESS have the same function as Sass does, where a variable can hold a default value, which may be overridden anywhere in the code, even before? In that case, would it be a feasible way to go having a LESS file with variable overrides somewhere in app space and then compiling it before the LESS files in package space during the build? I have no idea how or if the LESS module deals with uncompiled LESS code in packages (probably it doesn't), but maybe this should change in order to support our use case here. |
We're waiting @jlukic to finish the integration PR. He already started to merge it manually on the meteor branch but I guess he's very busy these days with the 1.7.x releases going on... After this, we should get official packages with plain CSS style files. The problem with the LESS variable customization is better summarize in this post by Jack where it make clear the inheritance problems with LESS with the current structure of the project. The good news might be that, once there will be a I'm more and more convinced that publishing different compiled themes or trying to find a way to let it easily customizable might be useless in view of this possibility. Basically you could do something like this: meteor create myApp
cd myApp
mkdir packages
cd packages
git clone https://github.com/Semantic-Org/Semantic-UI.git
cd Semantic-UI
....your customizations here ...
npm install
gulp install
cd ../../
meteor add semantic:ui
meteor What do you think about this? |
I spent the better half of this day trying to come up with a good strategy to include the official (as of yet) package and apply theming. I certainly did want to avoid using gulp grunt bower etc and the likes. I love meteor for its simplicity and its isomorphic nature where I don't need to master different tools for different tasks and I love that it is itself perfectly capable of building various sources. Meteor goes to great lengths to integrate everything into a single meteor command. No node install! No mongo install! No cordova tooling install! No android!... You see where I'm getting at. If only we had means to You know what, I'm almost two years into meteor development, and I'm still dead-scared of node, npm, gulp, bower... There... I said it... ;) |
@splendido is there anything we can do whilst waiting for #1607 to be merged to get Semantic UI working in Meteor with variables & customization etc? |
You can always drop in a zip file. |
Hi @jongold,
Unfortunately I'm not going to have time to look also into this: getting the canonical CSS packages (auto)published would be my personal goal... :( Any news @jlukic on the merging process of |
Is there a suggested way of using one of the pre-compiled templates to use as a base for a custom theme? Of course I'm asking for a way of doing it within meteor, not by cloning the semantic-ui repo. Basically, what next after I don't quite understand what zip file to drop in where. |
In the project I'm working on, I'm simply overriding whatever parts of the Semantic UI basic theme I don't like with simple CSS declarations. It is working okay, even if it's a bit bothersome and doesn't produce the nicest code... |
nicely put :) Ok, I guess it at least seems to be the most convenient among the alternatives. |
@nooitaf had a semantic-ui-less package (I never tried). |
@serkandurusoy i would suggest not using a package but just use the src folder from the semantic-ui source and add the less package, so it gets compiled by meteor. I didn't try it yet, but it should work. The semantic-ui-less package is deprecated, because the 1.0 source works differently somehow. |
@splendido I'm trying to rewrite the gulpfile while doing the meteor integration. I want to move all the tasks to individual js files and use If everyone prefers I can just drop in a package.js file and make things available immediately. I have not personally done any testing with using SUI package in Meteor however. I'd prefer to hold off until I can find a way to make LESS customization/build tools available in an easy to use set-up within a meteor package. I'm trying to get |
@nooitaf thanks, and thanks for providing the semantic-ui package all this time as well. But in light of @splendido 's comments:
I feer that path may lead to even more problems. Also, I will lose the convenience of As it currently stands, I fear there are two unquestionable options:
Yes there is a vast middle ground there, but they are all kind of hacks, overwrites and non-standard ways of achieving the goal. |
The discussion around Meteor integration and my current frustrations do not overshadow my appreciation for what you've been doing both with the framework itself and your embracing response with third party integrations. Kudos for that! |
I second @serkandurusoy in complimenting with Jack! @jlukic, perhaps dropping in the So we can start picking up some feed-back on it. What do you think? |
Before getting able to publish a customizable LESS package I really think we'd need to waint until things get improoved a bit on this side. There's a lot of active discussion about changing the way packages work, especially about letting the possibility to configure them before load time (in our case with SUI this would mean letting the possibility to specify some variables overwrite before LESS compilation...). See for example this card on the official trello roadmap or this discussion and this one on Meteor Community In the meanwhile I suggest to take a look at how Nemo64 allows for customization in his bootstrap package |
I just released Will weigh this all next week. I think all package managers are having the same issues. Build tools are locked inside PM folder which is treated akin to a I think the solve is the install process dropping the entire payload somewhere else. Preferably whatever it assumes is project root. |
Congrats on the |
For the Meteor package, please consider that the at that time the list of added files is picked up from the package folder, bundled with isobuild and uploaded to the packages server. Hence the only needs are:
So, to publish the SUI Meteor package, there are no build processes involved if you ensure to push compiled files to the repository everytime you make a new release. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Hi all,
I'd like to propose to start an official action for the integration of this awesome User Interface into the Meteor.js, the most popular full-stack JavaScript framework.
I'm starting off based on this very good attempt, about trying to put some order into the packages database for Meteor, started by @dandv.
He also promoted an official integration for FontAwesome opening this issue on their official GitHub repository which so far had nothing to do with Meteor.
Since he wrote his proposal in a very clean wording, I ask you to read it carefully since it can be exactly the same for Semantic-UI.
At the moment there are at least five different packages all simply wrapping semantic source code.
@lumatijev, @nooitaf are the maintainer of the most stared packages: I hope they'll also agree about taking a single official action for this.
My proposal, if you agree, is as follows:
Hope this make sense also to you...
Please let me know what do you think about this!
The text was updated successfully, but these errors were encountered: