From 9b26715fc94668d0da2b947801ab1e4499a06cbc Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Thu, 12 Dec 2024 12:24:22 +0530 Subject: [PATCH] allow tests to run for sameSite cookies in firefox and safari --- py/test/selenium/webdriver/common/cookie_tests.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/py/test/selenium/webdriver/common/cookie_tests.py b/py/test/selenium/webdriver/common/cookie_tests.py index df67ed78536c7..2743b8cee4e97 100644 --- a/py/test/selenium/webdriver/common/cookie_tests.py +++ b/py/test/selenium/webdriver/common/cookie_tests.py @@ -80,35 +80,24 @@ def test_add_cookie(cookie, driver): assert cookie["name"] in returned -@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_safari def test_add_cookie_same_site_strict(same_site_cookie_strict, driver): driver.add_cookie(same_site_cookie_strict) returned = driver.get_cookie("foo") assert "sameSite" in returned and returned["sameSite"] == "Strict" -@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_safari def test_add_cookie_same_site_lax(same_site_cookie_lax, driver): driver.add_cookie(same_site_cookie_lax) returned = driver.get_cookie("foo") assert "sameSite" in returned and returned["sameSite"] == "Lax" -@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented") -@pytest.mark.xfail_safari def test_add_cookie_same_site_none(same_site_cookie_none, driver): driver.add_cookie(same_site_cookie_none) # Note that insecure sites (http:) can't set cookies with the Secure directive. # driver.get_cookie would return None -@pytest.mark.xfail_ie -@pytest.mark.xfail_safari def test_adding_acookie_that_expired_in_the_past(cookie, driver): expired = cookie.copy() expired["expiry"] = calendar.timegm(time.gmtime()) - 1