You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert.Ignore($"{EnvironmentManager.Instance.Browser} does not support Chrome DevTools Protocol");
-return;
Apply this suggestion
Suggestion importance[1-10]: 7
Why: The suggestion correctly identifies that the return statement after Assert.Ignore is redundant since Assert.Ignore always throws an exception. Removing it improves code clarity and eliminates dead code.
7
Simplify collection validation by using LINQ instead of explicit iteration
The foreach loop for TimeDeltas contains only an assertion without any other logic. Consider using LINQ's All() method for a more concise and idiomatic check.
-foreach (var delta in profiler.TimeDeltas)-{- Assert.That(delta, Is.Not.Zero);-}+Assert.That(profiler.TimeDeltas.All(delta => delta != 0), Is.True, "All time deltas should be non-zero");
Apply this suggestion
Suggestion importance[1-10]: 5
Why: The suggestion proposes a more concise LINQ-based approach which is idiomatic in C#. While functionally equivalent, it's primarily a stylistic improvement that makes the code more readable but doesn't affect functionality.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvborisenko
changed the title
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Finishes future-proofing for a potential NUnit 4 upgrade. With this, I upgraded locally to NUnit 4.x and the tests ran and passed.
Motivation and Context
Fixes #14852
Types of changes
Checklist
PR Type
enhancement, tests
Description
DevToolsProfilerTest.csto ensureStartTime,EndTime, andTimeDeltasare non-zero, enhancing test robustness.DevToolsTestFixture.csby using string interpolation forAssert.Ignore.Changes walkthrough 📝
DevToolsProfilerTest.cs
Update NUnit assertions for profiler validationdotnet/test/common/DevTools/DevToolsProfilerTest.cs
StartTimeandEndTimeto check for non-zerovalues.
TimeDeltasto check for non-zero values.DevToolsTestFixture.cs
Use string interpolation for ignore messagedotnet/test/common/DevTools/DevToolsTestFixture.cs
Assert.Ignoremessage formatting to use string interpolation.