-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] add edge driver tests #14723
[py] add edge driver tests #14723
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
Looks like this test is failing in RBE |
tests are failing |
Signed-off-by: Viet Nguyen Duc <[email protected]>
This is a good catch, should we make an issue for adding all test cases to edge? |
This isn't working. Please check the action |
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
--------- Signed-off-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add Python driver tests for Edge Browser.
Motivation and Context
These were missing and it is required to test if everything is working on Edge or not
Types of changes
Checklist
PR Type
Tests
Description
Changes walkthrough 📝
__init__.py
Add initialization file for Edge driver tests
py/test/selenium/webdriver/edge/init.py
__init__.py
file for the Edge driver tests package.conftest.py
Add pytest fixture for Edge driver setup
py/test/selenium/webdriver/edge/conftest.py
driver instance.
edge_launcher_tests.py
Implement Edge browser launch and multiple instance tests
py/test/selenium/webdriver/edge/edge_launcher_tests.py
edge_service_tests.py
Add tests for Edge WebDriver service and logging
py/test/selenium/webdriver/edge/edge_service_tests.py