-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Added Deprecation of WebElement.get_attribute() per #13334 #14675
[py] Added Deprecation of WebElement.get_attribute() per #13334 #14675
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@VietND96 Failing test is unrelated |
Just pushed a fix for that flaky test actually #14701 |
@VietND96 now that the bidi_tests.py fix has been merged, could you run the ci workflow again? |
User description
Description
added deprecation warning to WebElement.get_attribute()
Motivation and Context
#13334
Types of changes
Checklist
PR Type
enhancement, documentation
Description
WebElement.get_attribute()
method in the Selenium WebDriver Python library.get_dom_attribute()
method instead.PRDescriptionHeader.CHANGES_WALKTHROUGH
webelement.py
Deprecate `WebElement.get_attribute()` method with warning
py/selenium/webdriver/remote/webelement.py
WebElement.get_attribute()
.get_dom_attribute()
instead.