From dabf659ce53af839e4c01d8292ffbed493ac18f2 Mon Sep 17 00:00:00 2001 From: Alex Rodionov Date: Wed, 1 May 2024 15:35:03 -0700 Subject: [PATCH] [rb] unfail some code --- .github/workflows/ci-ruby.yml | 81 +++++++++---------- .../spec_support/test_environment.rb | 2 - 2 files changed, 38 insertions(+), 45 deletions(-) diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 8653aab38f68e..67a315010ad6d 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -62,49 +62,44 @@ jobs: # --test_size_filters small # //rb/spec/... - # integration-tests-local: - # name: Local Tests - # needs: build - # uses: ./.github/workflows/bazel.yml - # strategy: - # fail-fast: false - # matrix: - # browser: - # - chrome - # - edge - # - firefox - # - safari - # os: - # - ubuntu - # - windows - # - macos - # exclude: - # - browser: edge - # os: ubuntu - # - browser: edge - # os: macos - # - browser: safari - # os: ubuntu - # - browser: safari - # os: windows - # # TODO: Investigate why they are timing out - # - browser: chrome - # os: windows - # - browser: edge - # os: windows - # with: - # name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }}) - # browser: ${{ matrix.browser }} - # cache-key: rb-${{ matrix.browser }}-test - # os: ${{ matrix.os }} - # run: > - # bazel test - # --build_tests_only - # --flaky_test_attempts 3 - # --local_test_jobs 1 - # --test_size_filters large - # --test_tag_filters ${{ matrix.browser }} - # //rb/spec/... + integration-tests-local: + name: Local Tests + needs: build + uses: ./.github/workflows/bazel.yml + strategy: + fail-fast: false + matrix: + browser: + - chrome + - edge + # - firefox + # - safari + os: + # - ubuntu + - windows + # - macos + exclude: + - browser: edge + os: ubuntu + - browser: edge + os: macos + - browser: safari + os: ubuntu + - browser: safari + os: windows + with: + name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }}) + browser: ${{ matrix.browser }} + cache-key: rb-${{ matrix.browser }}-test + os: ${{ matrix.os }} + run: > + bazel test + --build_tests_only + --flaky_test_attempts 3 + --local_test_jobs 1 + --test_size_filters large + --test_tag_filters ${{ matrix.browser }} + //rb/spec/... integration-tests-remote: name: Remote Tests diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb index 0184404035df2..f1864b587dfa3 100644 --- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb +++ b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb @@ -250,7 +250,6 @@ def safari_preview_driver(**opts) def chrome_options(args: [], **opts) opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY') args << '--headless=chrome' if ENV['HEADLESS'] - args << '--no-sandbox' args << '--disable-gpu' WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts) end @@ -258,7 +257,6 @@ def chrome_options(args: [], **opts) def edge_options(args: [], **opts) opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY') args << '--headless=chrome' if ENV['HEADLESS'] - args << '--no-sandbox' args << '--disable-gpu' WebDriver::Options.edge(browser_version: 'stable', args: args, **opts) end