Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual impl Default for EventTrigger #9

Closed
wants to merge 1 commit into from
Closed

Manual impl Default for EventTrigger #9

wants to merge 1 commit into from

Conversation

akimakinai
Copy link

#[derive(Default)] imposes an unnecessary generic bound T: Default for EventTrigger<T>. (rust-lang/rust#26925)

This prevented me to use EventTrigger for anEvent containing Entity (which is !Default) for example, as Default::default is the only way for constructing EventTrigger for users.

@Seldom-SE
Copy link
Owner

No longer necessary with dec8a58

@Seldom-SE Seldom-SE closed this Jan 13, 2024
@akimakinai akimakinai deleted the event_trigger_default branch August 30, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akimakinai @Seldom-SE