-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pixel maps to D110 geometry #51
Comments
The conflict in cms-sw#45117 comes from the transition to the new default geometry. Should I resolve the conflict by leaving our workflow in the previously default geometry (D98) and deal with the transition in an upcoming PR? |
it would be more clear to discuss conflicts inline in #30 |
I'm not sure I follow: in our PR |
ah, OK, I see; the file was changed to a generic |
Is T35 supposed to appear here soon, or is it the same as T33? I was thinking of looking at this while also addressing SegmentLinking/TrackLooper#329 since that was brought up in the review. |
Quoting the
I don't think this is a change in the actual layout, so T33 should be ok to look at at this level. The problem is that |
Could you remind me, did we agree that this is not an issue for us? @slava77 @ariostas @GNiendorf |
I think that elsewhere we concluded that our map files by construction do not depend on IT geometry, only OT module positions/sizes matter. |
Exactly, that's what I remember as well. I am closing this, thanks! |
With cms-sw#45175, the default Phase 2 geometry has been moved to D110 = T35+C18+M11+I17+O9+F8.
T35 constitutes a significant change in the inner tracker geometry wrt. T32 that we were using before:
As a result, I think that the pixel maps should be rederived for that geometry and tested, before we move to the new default.
The text was updated successfully, but these errors were encountered: