Quintuplet Kernels to Alpaka #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One additional note, the "matchRadiiXXXXXXXX" functions have a lot of repeated code that should be simplified. See #263 |
VourMa
reviewed
Apr 9, 2023
VourMa
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the two kernels and corresponding device functions in Quintuplet.cu to Alpaka.
Comparison between this PR and Master: Here
Comparison between the current alpaka_move and Master: Here
Master Validation Plots: Here
Current alpaka_move Validation Plots: Here
This PR Validation Plots: Here
Master Timing
Current alpaka_move Branch Timing
This PR Timing
