Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to 0.6 pT Maps + Add pT Runtime Toggle #409

Closed
wants to merge 4 commits into from
Closed

Conversation

GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented Jun 7, 2024

This PR sets the pt 0.6 GeV module maps as the default choice and moves the compile-time pT flag to a runtime pT option. I still need to make a corresponding PR on the CMSSW side.

@GNiendorf
Copy link
Member Author

/run standalone

Copy link

github-actions bot commented Jun 7, 2024

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     45.1    323.5    122.6     48.1     95.1    499.0    133.6    158.2     99.1      2.8    1527.1     983.0+/- 257.1     416.4   explicit_cache[s=4] (master)
   avg     43.5    322.9    148.2     48.0     94.8    504.0    125.1    178.8    100.5      2.2    1568.2    1020.6+/- 273.2     426.5   explicit_cache[s=4] (this PR)

@GNiendorf
Copy link
Member Author

/run standalone

@GNiendorf GNiendorf marked this pull request as ready for review June 7, 2024 14:21
Copy link

github-actions bot commented Jun 7, 2024

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     44.3    322.0    121.5     47.8     95.8    497.4    131.8    156.6    101.4      3.6    1522.1     980.5+/- 262.3     416.1   explicit_cache[s=4] (master)
   avg     45.3    321.1    147.1     46.6     95.0    497.1    124.9    179.4     98.4      2.2    1557.0    1014.7+/- 271.8     423.6   explicit_cache[s=4] (this PR)

@GNiendorf
Copy link
Member Author

Closing this PR, CMSSW PR is here: SegmentLinking/cmssw#39

@GNiendorf GNiendorf closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant