-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compilation flags for duplicate cleaning and triplet pLSs into runtime flags #408
Conversation
SDL/LST.h
Outdated
#include "Event.h" | ||
|
||
#include "Math/Vector3D.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these be avoided?
Especially the first one; to keep the dependencies cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were not added, they were just moved from the .cc
to the .h
file. Unless the movement is the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless the movement is the problem.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in 37b465a. I also included back the explicit SDL/Event.h
dependency for sdl.h
to make it clearer, even though it is implicitly included through write_sdl_ntuple.h
.
/run standalone |
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots. The full set of validation and comparison plots can be found here. Here is a timing comparison:
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All TracksThe full set of validation and comparison plots can be found here. |
Superseded by SegmentLinking/cmssw#37. |
As per title. The default behavior should not change, as it will be (hopefully) demonstrated by the tests, while I have run comparisons for the application of the flags, and the results are as expected:
Master vs. no duplicate cleaning
https://uaf-10.t2.ucsd.edu/~evourlio/SDL/PR408/runtimeFlags__VS_2_enabled_50fb47D-PU200_50fb47D-PU200/summary/
Master vs. triplet pLSs in TCs
https://uaf-10.t2.ucsd.edu/~evourlio/SDL/PR408/runtimeFlags__VS_3_enabled_50fb47D-PU200_50fb47D-PU200/summary/
It goes together with the corresponding PR in cmssw (SegmentLinking/cmssw#31).