Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in Triplet.h line 352 #407

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

jchismar
Copy link

Replaced + with *

@slava77
Copy link
Contributor

slava77 commented May 29, 2024

/runs standalone
/run cmssw

@slava77
Copy link
Contributor

slava77 commented May 29, 2024

/run standalone

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     47.8    322.6    122.0     47.3     96.0    490.8    133.7    157.4    100.4      2.1    1520.0     981.5+/- 261.0     416.8   explicit_cache[s=4] (master)
   avg     45.8    327.9    123.4     48.2     96.7    496.9    132.8    157.4    100.6      2.2    1531.9     989.2+/- 262.6     419.5   explicit_cache[s=4] (this PR)

Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77 slava77 merged commit cfbb863 into SegmentLinking:master May 30, 2024
3 checks passed
@@ -349,7 +349,7 @@ namespace SDL {
float drt_InSeg = rtMid - rtIn;
float dz_InSeg = zMid - zIn;
float dr3_InSeg =
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn + zIn);
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn * zIn);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would can potentially affect BBB T3s: the value of dr3_InSeg was slightly larger with the bug, which meant a slightly larger z selection window based on the track direction due to a larger component accounting for the multiple scattering. Realistically only T3s starting in barrel layer 1 may show something, but it looks like it was not visible even there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants