-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in Triplet.h line 352 #407
Conversation
/runs standalone |
/run standalone |
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots. The full set of validation and comparison plots can be found here. Here is a timing comparison:
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All TracksThe full set of validation and comparison plots can be found here. |
@@ -349,7 +349,7 @@ namespace SDL { | |||
float drt_InSeg = rtMid - rtIn; | |||
float dz_InSeg = zMid - zIn; | |||
float dr3_InSeg = | |||
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn + zIn); | |||
alpaka::math::sqrt(acc, rtMid * rtMid + zMid * zMid) - alpaka::math::sqrt(acc, rtIn * rtIn + zIn * zIn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would can potentially affect BBB T3s: the value of dr3_InSeg
was slightly larger with the bug, which meant a slightly larger z selection window based on the track direction due to a larger component accounting for the multiple scattering. Realistically only T3s starting in barrel layer 1 may show something, but it looks like it was not visible even there.
Replaced + with *