Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grove_gesture_sensor.py differs from Arduino C Code #33

Closed
pezi opened this issue Mar 6, 2021 · 1 comment
Closed

grove_gesture_sensor.py differs from Arduino C Code #33

pezi opened this issue Mar 6, 2021 · 1 comment
Assignees
Labels
grove.py Label for grove.py UAY Unassigned yet

Comments

@pezi
Copy link

pezi commented Mar 6, 2021

https://github.com/Seeed-Studio/grove.py/blob/master/grove/grove_gesture_sensor.py

		if data0 != 0x20  :#or data1 <> 0x76:
			print("Error with sensor")
		

Only one byte is checked - second check is commted out. Why?

if data == self.GES_FORWARD_FLAG:
				return 1
				time.sleep(self.GES_QUIT_TIME) 

Multiple dead code statments after return?

 } else if (data == GES_FORWARD_FLAG) {
                    Serial.println("Forward");
                    delay(GES_QUIT_TIME);
}
@MatthewJeffson MatthewJeffson added UAY Unassigned yet grove.py Label for grove.py labels Oct 9, 2024
@is-qian is-qian moved this from Todo to In Progress in Issues and PR Assemble Oct 16, 2024
@is-qian
Copy link
Contributor

is-qian commented Oct 16, 2024

Thanks for your suggestion. The dead code has been removed here.

@is-qian is-qian closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PR Assemble Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grove.py Label for grove.py UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

3 participants