Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit that adds pre-multiplied to images, also changes alpha for colored container? #180

Open
cybersoulK opened this issue Jul 14, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@cybersoulK
Copy link
Contributor

cybersoulK commented Jul 14, 2024

f893ad1

image image

The first image is before the commit, second is after the commit.
The elements are colored_box and colored_box_container

@LPGhatguy LPGhatguy added the bug Something isn't working label Jul 15, 2024
@LPGhatguy
Copy link
Member

Interesting! This should be an easy fix and probably impacts our game too.

@msparkles
Copy link
Contributor

@LPGhatguy we're noticing in #179 that the coloured texts are already premul'd (at least as far as we can tell)

We also found a really bad performance issue in the alpha premultiplication.

We're committing a fix for those because it heavily affects coloured texts, it takes like 5s to write 3 coloured text characters on release right now, Oops!

@msparkles
Copy link
Contributor

P.S. We ran a profiler on yakui example to see that premul'd alpha really is taking too long. It's all on .round()

@LPGhatguy
Copy link
Member

@msparkles Those changes seem useful even outside of cosmic text. If the conversion that removes round is the same, I'd take that in a separate PR.

I wonder where the best place to handle the premultiplication in the pipeline is.

@msparkles
Copy link
Contributor

Should we cherry-pick them into a separate branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants