Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAComboResponse doesn't work with socket streams #1145

Open
theseion opened this issue Jul 31, 2019 · 1 comment
Open

WAComboResponse doesn't work with socket streams #1145

theseion opened this issue Jul 31, 2019 · 1 comment

Comments

@theseion
Copy link
Member

theseion commented Jul 31, 2019

WAComboResponse and WAStremedResponse write to a socket stream directly.
ZdcSocketStream (Zinc) does not implement #crlf and stream nextPut: Character space fails because Characters can no longer be stored into a byte array (#nextPutAll: works because of the implicit conversion done by the VM in the primitive).

@theseion
Copy link
Member Author

theseion commented Jun 4, 2022

These issues would be taken care of by SeasideSt/Grease#138, which simply introduces two extensions. But see discussion in #1159. This might not be the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant