Skip to content

Commit

Permalink
Merge pull request #1149 from SeasideSt/1146-WAComboResponse-isnt-bei…
Browse files Browse the repository at this point in the history
…ng-flushed-as-stated-in-the-class-comment

1146 Fix WAComboResponse class comment
  • Loading branch information
Johan Brichau authored Aug 25, 2019
2 parents 4ba832d + 0624ce1 commit f678009
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ renderContentOn: aCanvas
"Render the search page"

self renderSearchLabelOn: aCanvas.
aCanvas flush. "flush before starting search to give immediate feedback"
self requestContext request flush. "flush before starting search to give immediate feedback"

self searchResultsDo:[:aResult|
self renderSearchResultOn: aCanvas.
aCanvas flush. "flush after each search result"
].
self searchResultsDo: [ :result |
self renderSearchResult: result on: aCanvas.
self requestContext request flush "flush after each search result" ]

After a response has been flushed once, header modifications are no longer possible and will raise a WAIllegalStateException.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"commentStamp" : "ar 8/4/2010 20:31",
"commentStamp" : "pmm 8/25/2019 11:14",
"super" : "WAResponse",
"category" : "Seaside-Core-HTTP",
"classinstvars" : [ ],
Expand Down

0 comments on commit f678009

Please sign in to comment.