Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless build in a project with large dependencies #129

Open
gautierrollin opened this issue Feb 18, 2020 · 2 comments
Open

Endless build in a project with large dependencies #129

gautierrollin opened this issue Feb 18, 2020 · 2 comments

Comments

@gautierrollin
Copy link

Hi!

I've been experimenting an endless build in my project when I tried to install a dependency with a huge dependency tree like aws-amplify.

Please note that without URLImportPlugin configured, my build works. I only get the problem with URLImportPlugin configured.

But if I comments these lines...

while (usedIds.has(hashId.substr(0, len))) {
len++;
}

...everything is working fine!

Do you have any idea about this?

Thanks!

@maraisr
Copy link
Collaborator

maraisr commented Feb 25, 2020

Are you able to provide us with minimally reproducible repo for this?

This should reach an end state, perhaps there is something else the matter. Those three lines were largely inspired by how webpack internally ensures unique ids for modules.

But yeah as I said, if you can provide a minimally reproducible repo, I'd be more than happy to take a closer look.

@gautierrollin
Copy link
Author

gautierrollin commented Mar 13, 2020

Sorry for my response time.

You can reproduce the issue with these two repos:

(Edit: Maybe I could have only made one repository 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants