Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback should stop on exceptions #67

Closed
spbnick opened this issue Dec 13, 2017 · 1 comment
Closed

Playback should stop on exceptions #67

spbnick opened this issue Dec 13, 2017 · 1 comment
Assignees
@spbnick
Labels
pr in progress pri: medium
Milestone
First release

Comments

@spbnick
Copy link
Member

spbnick commented Dec 13, 2017

When an exception, receiving, decoding or playing back a recording happens, playback should stop and an error message should be provided to the user, or at least on the console.

The issue #66 has shown it not to be the case.
@spbnick spbnick added this to the First release milestone Dec 13, 2017
@spbnick spbnick self-assigned this Dec 13, 2017
@sabbaka
Copy link

sabbaka commented Jan 5, 2018

Well, I've made something for now - https://youtu.be/vNjyqPT0weg. Anyway, we'll need to match this with a design.

@sabbaka sabbaka mentioned this issue Jan 5, 2018
Merged
sabbaka added a commit to sabbaka/cockpit that referenced this issue Jun 22, 2018
@sabbaka
Add error reporting
6cb85ed 
Fix Scribery#67
sabbaka added a commit that referenced this issue Jun 22, 2018
@sabbaka
Add error reporting
cb750db 
Fix #67
sabbaka added a commit to sabbaka/cockpit that referenced this issue Jun 22, 2018
@sabbaka
Add error reporting
7281130 
Fix Scribery#67
sabbaka added a commit to sabbaka/cockpit that referenced this issue Jun 22, 2018
@sabbaka
Add error reporting
cfffa3b 
Fix Scribery#67
sabbaka added a commit to sabbaka/cockpit that referenced this issue Sep 14, 2018
@sabbaka
Add error reporting
3835c32 
Fix Scribery#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spbnick spbnick

Labels
pr in progress pri: medium
Projects
None yet
Milestone
First release
Development

No branches or pull requests
2 participants
@spbnick @sabbaka