Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-89 Create merge pipeline #60

Merged
merged 9 commits into from
May 24, 2024
Merged

SFD-89 Create merge pipeline #60

merged 9 commits into from
May 24, 2024

Conversation

jantoun-scottlogic
Copy link
Contributor

@jantoun-scottlogic jantoun-scottlogic commented May 21, 2024

Jira ticket: https://scottlogic.atlassian.net/browse/SFD-89

Adds a workflow that runs when a pull request is opened and when new commits are pushed to an open pull request. The workflow checks the app builds successfully and runs the unit tests.

@jantoun-scottlogic jantoun-scottlogic force-pushed the add-merge-pipeline branch 11 times, most recently from fdf2ae8 to 025b22c Compare May 22, 2024 08:08
@jantoun-scottlogic jantoun-scottlogic marked this pull request as ready for review May 22, 2024 08:10
@jantoun-scottlogic jantoun-scottlogic changed the title TEST PR for adding merge pipeline SFD-89 Create merge pipeline May 22, 2024
@jantoun-scottlogic
Copy link
Contributor Author

Just added some documentation about how to skip running a workflow when pushing to a PR branch. It looks like this may actually bypass the requirement for the workflow to pass against the latest commit to allow merging so it's possible we may need to change a setting somewhere if we want to enforce that.

There are some other things we could tweak as well although we don't necessarily need to do them in this PR. E.g. it would be good to exclude some changes from triggering the pipeline/requiring it to pass before merging like if someone just updates the docs.

@jantoun-scottlogic jantoun-scottlogic merged commit 4a8ad42 into main May 24, 2024
2 checks passed
@jantoun-scottlogic jantoun-scottlogic deleted the add-merge-pipeline branch May 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants