diff --git a/vuu-ui/packages/vuu-data-react/src/hooks/useVuuMenuActions.ts b/vuu-ui/packages/vuu-data-react/src/hooks/useVuuMenuActions.ts index 23b750484e..c36ca2d9ff 100644 --- a/vuu-ui/packages/vuu-data-react/src/hooks/useVuuMenuActions.ts +++ b/vuu-ui/packages/vuu-data-react/src/hooks/useVuuMenuActions.ts @@ -1,12 +1,7 @@ import { DataSource, - DataSourceMenusMessage, DataSourceVisualLinkCreatedMessage, - DataSourceVisualLinkRemovedMessage, - DataSourceVisualLinksMessage, MenuRpcResponse, - VuuFeatureInvocationMessage, - VuuFeatureMessage, VuuUIMessageInRPCEditReject, VuuUIMessageInRPCEditResponse, } from "@finos/vuu-data"; @@ -16,7 +11,6 @@ import { MenuActionHandler, MenuBuilder, } from "@finos/vuu-data-types"; -import { GridAction } from "@finos/vuu-datagrid-types"; import { getFilterPredicate } from "@finos/vuu-filter-parser"; import { ClientToServerMenuCellRPC, @@ -185,7 +179,7 @@ export type VuuServerMenuOptions = { columnMap: ColumnMap; columnName: string; row: DataSourceRow; - selectedRowsCount: number; + selectedRows: DataSourceRow[]; viewport: string; }; diff --git a/vuu-ui/packages/vuu-data/src/connection-manager.ts b/vuu-ui/packages/vuu-data/src/connection-manager.ts index 33ed5c37d2..29c424ef03 100644 --- a/vuu-ui/packages/vuu-data/src/connection-manager.ts +++ b/vuu-ui/packages/vuu-data/src/connection-manager.ts @@ -17,6 +17,7 @@ import { } from "./data-source"; import * as Message from "./server-proxy/messages"; import { + ConnectionQualityMetrics, ConnectionStatusMessage, isConnectionQualityMetrics, isConnectionStatusMessage, @@ -32,7 +33,6 @@ import { // Note: inlined-worker is a generated file, it must be built import { workerSourceCode } from "./inlined-worker"; -import { ConnectionQualityMetrics } from "./vuuUIMessageTypes"; import { WebSocketProtocol } from "./websocket-connection"; import { TableSchema } from "./message-utils"; @@ -164,7 +164,6 @@ function handleMessageFromWorker({ } else if (isConnectionStatusMessage(message)) { ConnectionManager.emit("connection-status", message); } else if (isConnectionQualityMetrics(message)) { - console.log({ message }); ConnectionManager.emit("connection-metrics", message); } else { const requestId = (message as VuuUIMessageInRPC).requestId; diff --git a/vuu-ui/packages/vuu-data/src/json-data-source.ts b/vuu-ui/packages/vuu-data/src/json-data-source.ts index c50b740783..a3edb1c680 100644 --- a/vuu-ui/packages/vuu-data/src/json-data-source.ts +++ b/vuu-ui/packages/vuu-data/src/json-data-source.ts @@ -1,14 +1,13 @@ import { ColumnDescriptor, Selection } from "@finos/vuu-datagrid-types"; import { + ClientToServerEditRpc, + ClientToServerMenuRPC, LinkDescriptorWithLabel, - VuuGroupBy, VuuAggregation, + VuuGroupBy, VuuRange, - VuuSort, - ClientToServerMenuRPC, - ClientToServerEditRpc, - VuuColumnDataType, VuuRowDataItemType, + VuuSort, } from "@finos/vuu-protocol-types"; import { DataSourceFilter, DataSourceRow } from "@finos/vuu-data-types"; import { @@ -338,10 +337,6 @@ export class JsonDataSource this.#aggregations = aggregations; } - set data(data: JsonData) { - console.log(`set JsonDataSource data`); - } - get sort() { return this.#sort; } diff --git a/vuu-ui/packages/vuu-layout/test/layout-persistence/LocalLayoutPersistenceManager.test.ts b/vuu-ui/packages/vuu-layout/test/layout-persistence/LocalLayoutPersistenceManager.test.ts index dae22c9c69..200dbbda3a 100644 --- a/vuu-ui/packages/vuu-layout/test/layout-persistence/LocalLayoutPersistenceManager.test.ts +++ b/vuu-ui/packages/vuu-layout/test/layout-persistence/LocalLayoutPersistenceManager.test.ts @@ -263,7 +263,6 @@ describe("updateLayout", () => { it("errors if there are no metadata entries and multiple layouts in local storage with requested ID ", async () => { saveLocalEntity(layoutsSaveLocation, [existingLayout, existingLayout]); -<<<<<<< HEAD expectPromiseRejectsWithError( () => persistenceManager.updateLayout( @@ -271,11 +270,6 @@ describe("updateLayout", () => { metadataToUpdate, layoutToAdd ), -======= - expectError( - () => - persistenceManager.updateLayout(existingId, metadataToAdd, layoutToAdd), ->>>>>>> finos-main `No metadata with ID ${existingId}; Non-unique layout with ID ${existingId}` ); }); diff --git a/vuu-ui/sample-apps/feature-basket-trading/src/new-basket-panel/NewBasketPanel.css b/vuu-ui/sample-apps/feature-basket-trading/src/new-basket-panel/NewBasketPanel.css index e6116a0f9d..d6ece0fbe6 100644 --- a/vuu-ui/sample-apps/feature-basket-trading/src/new-basket-panel/NewBasketPanel.css +++ b/vuu-ui/sample-apps/feature-basket-trading/src/new-basket-panel/NewBasketPanel.css @@ -8,6 +8,7 @@ .vuuBasketNewBasketPanel-body { flex: 1 1 auto; + padding: 16px 0; } .vuuBasketNewBasketPanel-buttonBar { @@ -15,9 +16,7 @@ --saltButton-padding: 12px; display: flex; align-items: flex-end; - gap: 8px; - height: 32px; justify-content: flex-end; - padding: 0 16px; - -} \ No newline at end of file + padding-top: 8px; + gap: 8px; +} diff --git a/vuu-ui/showcase/src/examples/Table/TableNext.examples.tsx b/vuu-ui/showcase/src/examples/Table/TableNext.examples.tsx index f0fc3130bc..af67c56f71 100644 --- a/vuu-ui/showcase/src/examples/Table/TableNext.examples.tsx +++ b/vuu-ui/showcase/src/examples/Table/TableNext.examples.tsx @@ -6,7 +6,7 @@ import { View, } from "@finos/vuu-layout"; import { ContextPanel } from "@finos/vuu-shell"; -import { TableNext } from "@finos/vuu-table"; +import { GroupHeaderCellNext, TableNext } from "@finos/vuu-table"; import { ColumnSettingsPanel, TableSettingsPanel, @@ -14,7 +14,6 @@ import { import { ColumnDescriptor, TableConfig } from "@finos/vuu-datagrid-types"; import { CSSProperties, useCallback, useMemo, useState } from "react"; import { useTableConfig, useTestDataSource } from "../utils"; -import { GroupHeaderCellNext } from "@finos/vuu-table"; import { getAllSchemas } from "@finos/vuu-data-test"; import "./TableNext.examples.css"; diff --git a/vuu/src/main/scala/org/finos/vuu/provider/VuuJoinTableProvider.scala b/vuu/src/main/scala/org/finos/vuu/provider/VuuJoinTableProvider.scala index a259377916..11ce14c0f2 100644 --- a/vuu/src/main/scala/org/finos/vuu/provider/VuuJoinTableProvider.scala +++ b/vuu/src/main/scala/org/finos/vuu/provider/VuuJoinTableProvider.scala @@ -148,9 +148,6 @@ class VuuJoinTableProvider(implicit timeProvider: Clock, lifecycle: LifecycleCon def eventToKey(tableName: String, ev: util.HashMap[String, Any]): String = { val keyField = sourceTableDefsByName.get(tableName).keyField - if(keyField == null) - println("here") - ev.get(keyField).toString }