Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external dependencies for training strategies #194

Closed
MartinuzziFrancesco opened this issue Jan 16, 2024 · 0 comments · Fixed by #205
Closed

Add external dependencies for training strategies #194

MartinuzziFrancesco opened this issue Jan 16, 2024 · 0 comments · Fixed by #205
Labels
good first issue Good for newcomers v0.10

Comments

@MartinuzziFrancesco
Copy link
Collaborator

MartinuzziFrancesco commented Jan 16, 2024

Packages like LIBSVM or MLJLinearModels can be external (weak) dependencies.

Add a lower level function that takes the place of _train structured like train(algo::TrainingAlgo, states, target; kwargs...). The upper level function still maintains train(esn::AbstractReservoirComputer, target_data, training_algo; kwargs...). Additionally include a version that has train(esn::AbstractReservoirComputer, training_data, target_data, training_algo; kwargs...) to prepare for #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers v0.10
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant