Skip to content

Best Practices

vmagotra edited this page Sep 27, 2017 · 4 revisions

This is the page where we list "best practices" used when developing.

Pushing changes that are associated with a filed issue

git checkout master  
git pull  
git checkout -b NN_description-of-issue (where NN is the issue number)  
make changes to fix issue
run tests 
commit changes to local branch
git push origin <branch name>  
Switch to GitHub, create pull request  
assign pull request to yourself  
assign reviewer (if significant)  

In case there is an update for the pull request...

git commit -am "blah"  
git checkout master  
git pull  
git checkout <branch>  
git merge master  
(fix things)  
run tests  
git push origin <branch>