You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently our static UrlLogger will have an issue if multiple tests that use it are run at the same time.
One option is to get the job name in any function that needs to log, and have it pass that in the logging request. Then the UrlLoggerImpl could segment results by this key (and provide a clear(key) call).
Each test that relies on logging would need to call UrlLogger.clear(test name), and ensure that the job being run sets the job name to be the test name.
The text was updated successfully, but these errors were encountered:
I poked at this a little. The problem is getting at the job name from within a function. We've got it in the CrawlTopology, and it gets passed to the ExecutionEnvironment, but it doesn't seem to be accessible from the ExecutionEnvironment, let alone anything actually accessible to a function.
I was hoping that we didn't have to add jobName as a parameter in the constructor of every single function we're using.
Currently our static
UrlLogger
will have an issue if multiple tests that use it are run at the same time.One option is to get the job name in any function that needs to log, and have it pass that in the logging request. Then the
UrlLoggerImpl
could segment results by this key (and provide aclear(key)
call).Each test that relies on logging would need to call
UrlLogger.clear(test name)
, and ensure that the job being run sets the job name to be the test name.The text was updated successfully, but these errors were encountered: