Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loadingOverlay public #61

Open
healermagnus opened this issue Sep 27, 2024 · 0 comments
Open

Make loadingOverlay public #61

healermagnus opened this issue Sep 27, 2024 · 0 comments

Comments

@healermagnus
Copy link

healermagnus commented Sep 27, 2024

Is your feature request related to a problem? Please describe.
We are subclassing the existing library quite successfully, but I keep tripping on the LoadingOverlay, which takes the very useful name loadingOverlay.

Unfortunately this member variable is marked private, so when subclassing SPSApplication I am stuck with this variable that I don't want, can't subclass, can't access from a subclass, etc., and also I can't make a variable with that useful name.

Describe the solution you'd like
For the other class members from Epic, like afkOverlay and connectOverlay, etc, I have a public member I can override and subclass and it's awesome.

I would like for line 13 of SPSApplication.ts to be:

public loadingOverlay TextOverlay;

That would solve what is an otherwise awesome library to use, and thank you for it.

Describe alternatives you've considered
The alternative solution I've been relegated to is basically ignoring this class member, and subclassing around anything that refers to it.

Additional context
I was trying to submit a PR with this change, but I don't have that level of access to the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant