Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] Add a test case for metadata repair on capsule complete sync (#16835) #17155

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 12, 2024

Problem Statement

Fix for the issue linked bellow has been backported to 6.16.1. We already have test coverage for this in stream and could have the same in 6.16.z.

Solution

git cherry-pick <id> && git push 6.16.z

Related Issues

https://issues.redhat.com/browse/SAT-29702

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_complete_sync_fixes_metadata

…teQE#16835)

* Add a test case for metadata repair on capsule complete sync

* Harden the test case with contenthost actions
@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 12, 2024
@vsedmik vsedmik self-assigned this Dec 12, 2024
@vsedmik vsedmik requested a review from a team as a code owner December 12, 2024 09:30
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 12, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_complete_sync_fixes_metadata

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9600
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_complete_sync_fixes_metadata --external-logging
Test Result : ===== 1 passed, 25 deselected, 39 warnings, 1 error in 2264.29s (0:37:44) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 12, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 12, 2024

^ checkin failed at AAP at teardown. Unrelated but rerunning...

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9601
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_complete_sync_fixes_metadata --external-logging
Test Result : ========== 1 passed, 25 deselected, 39 warnings in 1776.68s (0:29:36) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 12, 2024
@pondrejk
Copy link
Contributor

@vsedmik non blocking question, shouldn't this be checked also with some RH repo?

@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 12, 2024

@vsedmik non blocking question, shouldn't this be checked also with some RH repo?

@pondrejk in this case the root cause was in the way how the complete sync was (or actually was not) triggered. It is independent from "what actual metadata" are repaired.
On the other hand I could imagine hardening this test case a bit with wider metadata set being fixed/tested, for example kickstart-specific content like treeinfo etc. But such an update would probably need to come through the master branch first (this is only cherry-pick). Anyway thank you for the tip, I have put it on my improvements list.

@vsedmik vsedmik merged commit 81d1ee4 into SatelliteQE:6.16.z Dec 13, 2024
20 checks passed
@vsedmik vsedmik deleted the 6.16.z-caps-fix-metadata branch December 13, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants