Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting test fixes for stream #17116

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Reporting test fixes for stream #17116

merged 5 commits into from
Dec 10, 2024

Conversation

LadislavVasina1
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 commented Dec 9, 2024 •
edited
Loading

Problem Statement

There were multiple outdated Reporting UI tests that did not work correctly with stream.

Solution

This PR fixes these issues.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k "test_positive_schedule_generation_and_get_mail or test_positive_installable_errata_with_user or test_positive_generate_subscriptions_report_json or test_positive_generate_all_installed_packages_report"

@LadislavVasina1 LadislavVasina1 added UI Issues and PRs involving the UI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 9, 2024
@LadislavVasina1 LadislavVasina1 self-assigned this Dec 9, 2024
@LadislavVasina1 LadislavVasina1 requested a review from a team as a code owner December 9, 2024 15:02
@LadislavVasina1 LadislavVasina1 requested a review from a team as a code owner December 9, 2024 18:51
@LadislavVasina1 LadislavVasina1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 9, 2024
@LadislavVasina1 LadislavVasina1 removed the request for review from a team December 9, 2024 20:19
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 9, 2024
@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k "test_positive_schedule_generation_and_get_mail or test_positive_installable_errata_with_user or test_positive_generate_subscriptions_report_json or test_positive_generate_all_installed_packages_report"

vsedmik
vsedmik approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The PRT is failing because of https://issues.redhat.com/browse/SAT-30043

No need to hook it :BlockedBy: SAT-30043 since many other cases are affected too and I expect a quick fix for that.

@ogajduse ogajduse enabled auto-merge (squash) December 10, 2024 15:47
@ogajduse ogajduse merged commit 5abd4bc into SatelliteQE:master Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@chris1984 chris1984 Awaiting requested review from chris1984

@jeremylenz jeremylenz Awaiting requested review from jeremylenz

@sambible sambible Awaiting requested review from sambible

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

Assignees

@LadislavVasina1 LadislavVasina1

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LadislavVasina1 @vsedmik @ogajduse @Satellite-QE