-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ISS mixed content export case with flatpak and import #17107
Open
vsedmik
wants to merge
1
commit into
SatelliteQE:master
Choose a base branch
from
vsedmik:add-flatpak-iss
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
No-CherryPick
PR doesnt need CherryPick to previous branches
Stream
Introduced in or relating directly to Satellite Stream/Master
labels
Dec 6, 2024
|
PRT Result
|
Satellite-QE
added
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Dec 6, 2024
pondrejk
approved these changes
Dec 12, 2024
vsedmik
force-pushed
the
add-flatpak-iss
branch
from
December 13, 2024 10:29
610551f
to
8c166d1
Compare
rebased |
Satellite-QE
removed
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Dec 13, 2024
|
looks like |
with - flatpak-type repository - import section
vsedmik
force-pushed
the
add-flatpak-iss
branch
from
December 13, 2024 13:12
8c166d1
to
26d4566
Compare
|
PRT Result
|
Satellite-QE
added
the
PRT-Failed
Indicates that latest PRT run is failed for the PR
label
Dec 13, 2024
|
PRT Result
|
Satellite-QE
added
PRT-Passed
Indicates that latest PRT run is passed for the PR
and removed
PRT-Failed
Indicates that latest PRT run is failed for the PR
labels
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No-CherryPick
PR doesnt need CherryPick to previous branches
PRT-Passed
Indicates that latest PRT run is passed for the PR
Stream
Introduced in or relating directly to Satellite Stream/Master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Satellite 6.17 introduces support for Flatpak content.
In #17013 (this PR is based on that) we add basic support and cases for flatpaks.
As per the issue linked bellow we also need to ensure that ISS export and import work for flatpaks the same as for standard container-type repositories.
Solution
We already have a test case for mixed content-types export (including container) so I've decided to extend it with a flatpak repo and the import portion (which we needed anyway).
Flatpak repo creation somewhat differs from other repos (it can be created only by mirroring of a remote-repo after a flatpak-remote scans the remote index), but that's handled by the
function_synced_flatpak_repo
fixture. OSome additional minor fixes:
In this PR please focus just on the ISS part in
tests/foreman/cli/test_satellitesync.py
(the rest is reviewed in #17013)
Related Issues
https://issues.redhat.com/browse/SAT-29562
PRT test Cases example