Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ISS mixed content export case with flatpak and import #17107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 6, 2024

Problem Statement

Satellite 6.17 introduces support for Flatpak content.
In #17013 (this PR is based on that) we add basic support and cases for flatpaks.

As per the issue linked bellow we also need to ensure that ISS export and import work for flatpaks the same as for standard container-type repositories.

Solution

We already have a test case for mixed content-types export (including container) so I've decided to extend it with a flatpak repo and the import portion (which we needed anyway).

Flatpak repo creation somewhat differs from other repos (it can be created only by mirroring of a remote-repo after a flatpak-remote scans the remote index), but that's handled by the function_synced_flatpak_repo fixture. O

Some additional minor fixes:

  • removed the extra product for the container-repo (all repos share just one product)
  • removed some obvious comments

In this PR please focus just on the ISS part in tests/foreman/cli/test_satellitesync.py
(the rest is reviewed in #17013)

Related Issues

https://issues.redhat.com/browse/SAT-29562

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos
Katello:
  katello: 11223
  hammer-cli-katello: 971

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 6, 2024
@vsedmik vsedmik self-assigned this Dec 6, 2024
@vsedmik vsedmik requested review from a team as code owners December 6, 2024 17:55
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 6, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos
Katello:
  katello: 11223
  hammer-cli-katello: 971

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9552
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos --external-logging
Test Result : ========== 1 passed, 36 deselected, 45 warnings in 1565.71s (0:26:05) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 6, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2024

rebased

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 13, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos

@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2024

looks like pip install -qU -r requirements.txt failed in PRT

with
- flatpak-type repository
- import section
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9619
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos --external-logging
Test Result : =========== 36 deselected, 45 warnings, 1 error in 836.24s (0:13:56) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 13, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 13, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos
Katello:
  katello: 11223
  hammer-cli-katello: 971

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9620
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_satellitesync.py -k test_postive_export_import_cv_with_mixed_content_repos --external-logging
Test Result : ========== 1 passed, 36 deselected, 45 warnings in 1619.50s (0:26:59) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants