CVE-2024-8553

[lhellebr]

No description provided.

[vsedmik]

trigger: test-robottelo
pytest: tests/foreman/cli/test_reporttemplates.py::test_positive_generate_report_check_for_injection tests/foreman/ui/test_jobtemplate.py::test_positive_preview_template_check_for_injection

[Satellite-QE]

PRT Result

Build Number: 9569
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_reporttemplates.py::test_positive_generate_report_check_for_injection tests/foreman/ui/test_jobtemplate.py::test_positive_preview_template_check_for_injection --external-logging
Test Result : ============ 2 failed, 2 passed, 228 warnings in 1523.14s (0:25:23) ============

[vsedmik]

Codewisely looks good, but the UI cases failed with:

AttributeError: Object <<class 'airgun.views.common.TemplateEditor'>> has no widget name "error"

Do we need some Airgun changes for them to pass @lhellebr ?

[lhellebr]

Oh yes, stupid me. SatelliteQE/airgun#1649

[lhellebr]

trigger: test-robottelo
pytest: tests/foreman/cli/test_reporttemplates.py::test_positive_generate_report_check_for_injection tests/foreman/ui/test_jobtemplate.py::test_positive_preview_template_check_for_injection
airgun: 1649

[Satellite-QE]

PRT Result

Build Number: 9579
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_reporttemplates.py::test_positive_generate_report_check_for_injection tests/foreman/ui/test_jobtemplate.py::test_positive_preview_template_check_for_injection --external-logging
Test Result : ================= 4 passed, 223 warnings in 1439.97s (0:23:59) =================

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (2)

tests/foreman/ui/test_jobtemplate.py:15

• [nitpick] The function name gen_alpha is unclear. It should be renamed to generate_alpha_string for better clarity.

from fauxfactory import gen_alpha, gen_string

tests/foreman/ui/test_jobtemplate.py:271

• [nitpick] The error message is too verbose and could be simplified to improve readability. Consider rephrasing to: 'Error during rendering: 'select' must be a Symbol or Array of Symbols. Save template input changes before previewing.'

"Problem with previewing the template: error during rendering: Value of 'select' passed to load_users must be Symbol or Array of Symbols. Note that you must save template input changes before you try to preview it."

[lhellebr]

Dear Copilot, all three of your catches are wrong.

1. I didn't choose name of gen_string in this PR
2. I didn't choose the exact wording of that error message either, it's in the product
3. The 'file' parameter should be a path to a file, not the content itself. is simply not true, that's not how Robottelo treats it.