Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation coverage for SAT-28695 #17044

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

$ insights-client --ansible-host=foo.example.com fails when execute
BZ - SAT-28695

Solution

This PR will test this BZ scenario in 6.16.z and 6.15.z

Related Issues

https://issues.redhat.com/browse/SAT-28695

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_register_insights_client_host'

@vijaysawant vijaysawant added Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 2, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner December 2, 2024 14:20
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_register_insights_client_host'

@vijaysawant vijaysawant added the CherryPick PR needs CherryPick to previous branches label Dec 2, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9504
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_register_insights_client_host --external-logging
Test Result : ========= 3 passed, 32 deselected, 130 warnings in 2070.66s (0:34:30) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 2, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 minor things.

tests/foreman/cli/test_rhcloud_inventory.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_rhcloud_inventory.py Show resolved Hide resolved
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending comments

@vijaysawant
Copy link
Contributor Author

@ColeHiggins2 would like to know your thoughts about this test scenario and test module (cli/test_rhcloud_inventory.py) in which this test case has been added.
Is it correct test module to add insights client test scenario? Or should be good to create new file as like UI tests has?

CLI Tests:
cli/test_rhcloud_inventory.py

UI Tests:
robottelo/tests/foreman/ui/test_rhc.py
robottelo/tests/foreman/ui/test_rhcloud_insights.py
robottelo/tests/foreman/ui/test_rhcloud_inventory.py

Are we planning to add more scenarios in future for RH-Clould?

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_register_insights_client_host'

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 3, 2024
@vijaysawant vijaysawant requested a review from vsedmik December 3, 2024 07:37
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9507
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_register_insights_client_host --external-logging
Test Result : ===== 2 passed, 32 deselected, 132 warnings, 1 error in 1776.46s (0:29:36) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 3, 2024
@vsedmik
Copy link
Contributor

vsedmik commented Dec 3, 2024

Hmm, looks like we need to add the RHEL10 repo into settings and bellow.

09:10:43          distro_repo_map = {
09:10:43              'rhel6': settings.repos.rhel6_os,
09:10:43              'rhel7': settings.repos.rhel7_os,
09:10:43              'rhel8': settings.repos.rhel8_os,
09:10:43              'rhel9': settings.repos.rhel9_os,
09:10:43          }
09:10:43          rhel_repo = distro_repo_map.get(rhel_distro)
09:10:43      
09:10:43          if rhel_repo is None:
09:10:43  >           raise ContentHostError(f'Missing RHEL repository configuration for {rhel_distro}.')
09:10:43  E           robottelo.hosts.ContentHostError: Missing RHEL repository configuration for rhel10.

Are you on the settings part already @damoore044 ?

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_register_insights_client_host'

@damoore044
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_register_insights_client_host'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9532
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_register_insights_client_host --external-logging
Test Result : ========= 3 passed, 32 deselected, 134 warnings in 2209.39s (0:36:49) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 4, 2024
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 4, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9535
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_register_insights_client_host --external-logging
Test Result : ========= 3 passed, 32 deselected, 134 warnings in 2281.73s (0:38:01) ==========

@vsedmik vsedmik merged commit 1b64d7c into SatelliteQE:master Dec 5, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
* automation coverage for SAT-28695

* Update tests/foreman/cli/test_rhcloud_inventory.py

Co-authored-by: vsedmik <[email protected]>

* Update tests/foreman/cli/test_rhcloud_inventory.py

Co-authored-by: vsedmik <[email protected]>

---------

Co-authored-by: vsedmik <[email protected]>
Co-authored-by: David Moore <[email protected]>
(cherry picked from commit 1b64d7c)
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
* automation coverage for SAT-28695

* Update tests/foreman/cli/test_rhcloud_inventory.py

Co-authored-by: vsedmik <[email protected]>

* Update tests/foreman/cli/test_rhcloud_inventory.py

Co-authored-by: vsedmik <[email protected]>

---------

Co-authored-by: vsedmik <[email protected]>
Co-authored-by: David Moore <[email protected]>
(cherry picked from commit 1b64d7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants