-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flatpak CLI support and CRUD case #17013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
No-CherryPick
PR doesnt need CherryPick to previous branches
Stream
Introduced in or relating directly to Satellite Stream/Master
labels
Nov 28, 2024
|
PRT Result
|
Satellite-QE
added
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Nov 28, 2024
vsedmik
force-pushed
the
add-flatpak-cli
branch
from
November 29, 2024 08:07
25e81be
to
832e22e
Compare
Satellite-QE
removed
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Nov 29, 2024
pondrejk
approved these changes
Nov 29, 2024
|
PRT Result
|
Satellite-QE
added
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Nov 29, 2024
synkd
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One non-blocking suggestion.
Satellite-QE
removed
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Dec 4, 2024
|
vsedmik
force-pushed
the
add-flatpak-cli
branch
from
December 5, 2024 17:10
411d124
to
9c4abb8
Compare
PRT Result
|
Satellite-QE
added
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Dec 5, 2024
|
PRT Result
|
Satellite-QE
added
PRT-Failed
Indicates that latest PRT run is failed for the PR
and removed
PRT-Passed
Indicates that latest PRT run is passed for the PR
labels
Dec 6, 2024
vsedmik
force-pushed
the
add-flatpak-cli
branch
from
December 9, 2024 10:36
9c4abb8
to
ab64bf1
Compare
The PRT above ^ failed due to undergoing organization-scoping changes of remotes in the upstream. |
LadislavVasina1
approved these changes
Dec 9, 2024
|
PRT Result
|
Satellite-QE
added
PRT-Passed
Indicates that latest PRT run is passed for the PR
and removed
PRT-Failed
Indicates that latest PRT run is failed for the PR
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in progress
This issue is being worked on
No-CherryPick
PR doesnt need CherryPick to previous branches
PRT-Passed
Indicates that latest PRT run is passed for the PR
Stream
Introduced in or relating directly to Satellite Stream/Master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Satellite 6.17 introduces support for Flatpak content. We should introduce some automation around.
Solution
This PR just adds one test case for CRUD + scan and one test case to verify the scan finds all repos available in the remote index.
Related Issues
https://issues.redhat.com/browse/SAT-28471
PRT test Cases example