Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a contenthost_factory to perform post-deploy actions #16981

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JacobCallahan
Copy link
Member

The intent of this change is to enable us to add post-deploy actions when requesting specific types of content hosts, like fips-enabled. Users can define a set of host_post_configs in conf/content_host.yaml file. They can then add the post config action under the host definition.

@JacobCallahan JacobCallahan added enhancement An addition to the robottelo framework Framework Changes A modification of the robottelo framework CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • conf/content_host.yaml.template: Language not supported
The intent of this change is to enable us to add post-deploy actions
when requesting specific types of content hosts, like fips-enabled.
Users can define a set of host_post_configs in conf/content_host.yaml
file. They can then add the post config action under the host
definition.
@jyejare
Copy link
Member

jyejare commented Nov 26, 2024

@JacobCallahan I think the approach shown in https://github.com/SatelliteQE/robottelo/pull/16903/files is much more straightforward and has fewer changes needed to make this change today and in future as well.

Though I agree that the post deploy configs are not visible within the module and happen behind the scenes but its not impossible to find those. Hense I sold on the idea of #16903 (comment) , else I too had a similar structure defined before changing my mind.

CC: @ogajduse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches enhancement An addition to the robottelo framework Framework Changes A modification of the robottelo framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants