From ffbdc02c427a685915791343097d5b8236f4a364 Mon Sep 17 00:00:00 2001 From: Gaurav Talreja Date: Tue, 9 Apr 2024 20:17:05 +0530 Subject: [PATCH] Remove codecov (#1131) This continues a trend we've done with other projects. Codecov has some use in other types of projects, but really isn't a good fit for Nailgun since it is functionally exercised by Robottelo. Without getting too deep into philosophy, CodeCov is a misleading metric for quality and minor changes are largely ignored in mature projects. (cherry picked from commit ef2c9e7c3efcef451d379a2b860adc726ae1c110) Co-authored-by: Jacob Callahan --- .codecov.yml | 7 ------- .github/workflows/merge_to_master.yml | 9 --------- .github/workflows/pull_requests.yml | 9 ++------- Makefile | 6 +----- pyproject.toml | 3 --- requirements-dev.txt | 4 ---- 6 files changed, 3 insertions(+), 35 deletions(-) delete mode 100644 .codecov.yml diff --git a/.codecov.yml b/.codecov.yml deleted file mode 100644 index af69e1f0..00000000 --- a/.codecov.yml +++ /dev/null @@ -1,7 +0,0 @@ -github_checks: - annotations: false - -# https://docs.codecov.io/docs/github-checks-beta -# Annotations are shown for unchanged files on the diff -# Turn off all annotations until this is more configurable -# The codecov comment will still be made on the PR diff --git a/.github/workflows/merge_to_master.yml b/.github/workflows/merge_to_master.yml index a87ff2f9..e13e3a13 100644 --- a/.github/workflows/merge_to_master.yml +++ b/.github/workflows/merge_to_master.yml @@ -42,10 +42,6 @@ jobs: - name: Pre Commit Checks uses: pre-commit/action@v3.0.0 - - name: Test Nailgun Coverage - run: | - make test-coverage - - name: Make Docs run: | make docs-html @@ -60,11 +56,6 @@ jobs: if: failure() run: git diff - - name: Upload Codecov Coverage - uses: codecov/codecov-action@v1.0.13 - with: - fail_ci_if_error: true - build-n-publish: name: Build and publish Python 🐍 distributions 📦 to PyPI runs-on: ubuntu-latest diff --git a/.github/workflows/pull_requests.yml b/.github/workflows/pull_requests.yml index 0aed4807..feb29cf5 100644 --- a/.github/workflows/pull_requests.yml +++ b/.github/workflows/pull_requests.yml @@ -38,9 +38,8 @@ jobs: pip install --compile --no-cache-dir pycurl pip install -U -r requirements.txt -r requirements-dev.txt --no-cache-dir - - name: Test Nailgun Coverage - run: | - make test-coverage + - name: Run Tests + run: make test - name: Make Docs run: | @@ -56,7 +55,3 @@ jobs: if: failure() run: git diff - - name: Upload Codecov Coverage - uses: codecov/codecov-action@v1.0.13 - with: - fail_ci_if_error: true diff --git a/Makefile b/Makefile index 7f64dcd1..2d729e59 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,6 @@ help: @echo "Please use \`make ' where is one of:" @echo " help to show this message" @echo " test to run unit tests" - @echo " test-coverage to run unit tests and measure test coverage" @echo " docs-html to generate HTML documentation" @echo " docs-clean to remove documentation" @echo " package to generate installable Python packages" @@ -21,9 +20,6 @@ docs-clean: test: python $(TEST_OPTIONS) -test-coverage: - coverage run --source nailgun $(TEST_OPTIONS) - package: ./setup.py sdist bdist_wheel --universal @@ -33,4 +29,4 @@ package-clean: publish: package twine upload dist/* -.PHONY: help docs-html docs-clean test test-coverage package package-clean publish +.PHONY: help docs-html docs-clean test package package-clean publish diff --git a/pyproject.toml b/pyproject.toml index 708a464e..d668c4e3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -117,6 +117,3 @@ combine-as-imports = true [tool.ruff.mccabe] max-complexity = 25 -[tool.coverage.run] -omit = ["tests/*"] -include = ["nailgun/*.py"] diff --git a/requirements-dev.txt b/requirements-dev.txt index 40e934c7..c373d7c7 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -14,9 +14,5 @@ wheel # For `make publish` twine -# For code coverage -codecov==2.1.13 -coverage[toml] - # For linting ruff