Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for a new tab for Scanner which can explain on how scanners can evaluation there performance #60

Open
preetkaran20 opened this issue Feb 20, 2022 · 3 comments
Labels

Comments

@preetkaran20
Copy link
Member

Is your feature request related to a problem? Please describe.

If we read about the goals of VulnerableApp/VulnerableApp-Facade, this application is built to help scanners like DAST and SAST in evaluating themselves so in order to help SAST, projects need to provide a file-like VulnerabilityDefinition, similarly, for DAST, Vulnerable Applications expose Scanner endpoint which can be used by DAST like Owasp ZAP.
Our VulnerableApp/VulnerableApp-jsp/VulnerableApp-php all expose scanner endpoint, so if you start the application then visit
/<VulnerableApplicationName>/scanner endpoint, you can find the json data.

The requirement is to add a button in the header (or any other suitable place, upto the implementer) which is say Scanners or something suitable which is clicked and then it opens up a menu bar with 2 options, one for DAST and one for SAST.
In DAST, we need to explain, how DAST scanners can utilise the VulnerableApp-facade and similarly under SAST we need to explain, how SAST can utilise the VulnerableApp-facade.

Initial thought:
Screenshot 2022-02-20 at 8 44 27 AM

DAST /scanner endpoint data:
image

Apart from User interface work, we also need to add a merging logic in LUA such that when ever user enters /scanner endpoint, we merge responses from all /<VulnerableApplicationName>/scanner endpoints and show the result. Something similar to: https://github.com/SasanLabs/VulnerableApp-facade/blob/main/lua-modules/vulnerableapp_utility.lua

Content of DAST and SAST menu options
For content relation information look at: https://sasanlabs.github.io/VulnerableApp/HOW-TO-USE.html#how-sast-or-dast-can-use-the-project

@preetkaran20 preetkaran20 added enhancement New feature or request good first issue Good for newcomers Thinking New labels Feb 20, 2022
@merry-degaga
Copy link
Contributor

Hi Karan, I am interested in working on this issue.

@merry-degaga
Copy link
Contributor

Hi Karan,
While testing out the scanner endpoints it seems only VulnerableApp/scanner returns the json information and VulnerableApp-jsp/scanner and VulnerableApp-php/scanner are not yet available (issues: SasanLabs/VulnerableApp-jsp#8
SasanLabs/VulnerableApp-php#13 )

From this it looks like I am blocked for now from completing this...I could look into the issue SasanLabs/VulnerableApp-jsp#8 since I am more familiar with java...Would this be okay?
Or let me continue with this issue and update nginx.conf with only the VulnerableApp/scanner endpoint?

@preetkaran20
Copy link
Member Author

Hi @merry-degaga ,

Yes, other Vuln apps don't support scanner endpoint so for now in lua script you can invoke scanner endpoints on those apps as well and in case of failure just ignore the response else merge it. The same is being done for vulnerability definitions endpoint as well.

Thanks,
Karan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants