Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: provide a prop to opt out of the default behaviour of focus returning to the triggering button #7085

Open
1 task done
amieedwards-sage opened this issue Nov 20, 2024 · 1 comment · May be fixed by #7098
Open
1 task done

Dialog: provide a prop to opt out of the default behaviour of focus returning to the triggering button #7085

amieedwards-sage opened this issue Nov 20, 2024 · 1 comment · May be fixed by #7098
Labels
Bug On Backlog Squad Nebula

Comments

@amieedwards-sage
Copy link

Description

I want to be able to override the default focus behaviour of the Dialog on close, to provide a better experience for the user.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-8kzldp?file=src%2FApp.tsx

Steps to reproduce

  • Open voiceover
  • Navigate to Open dialog button and click it
  • Close Dialog
  • Focus is returned back to the button
  • Aria-live section is not read out as expected

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

144.9.2

Design tokens version

4.35.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@amieedwards-sage amieedwards-sage added Bug triage Triage Required labels Nov 20, 2024
@tomdavies73
Copy link
Contributor

FE-7005

@tomdavies73 tomdavies73 added On Backlog Squad Nebula and removed triage Triage Required labels Nov 25, 2024
tomdavies73 added a commit that referenced this issue Nov 27, 2024
@tomdavies73
feat(sidebar): add preventFocusRestore prop
6a8bda8 
fix #7085
tomdavies73 added a commit that referenced this issue Nov 27, 2024
@tomdavies73
feat: add preventFocusRestore prop to useModalManager hook
4e9cc35 
fix #7085
@tomdavies73 tomdavies73 linked a pull request Nov 27, 2024 that will close this issue
Draft
14 tasks
tomdavies73 added a commit that referenced this issue Nov 27, 2024
@tomdavies73
feat: add preventFocusRestore prop to useModalManager hook
77d9913 
fix #7085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add preventFocusRestore prop to modal based components Sage/carbon
2 participants
@tomdavies73 @amieedwards-sage